Skip to content

Show "unused catalog protocols warnings/errors" only if the unused catalog is one of the workspace's default catalogs#30

Merged
suhdonghwi merged 4 commits intomainfrom
feat/accurate-validation-2
Nov 10, 2025
Merged

Show "unused catalog protocols warnings/errors" only if the unused catalog is one of the workspace's default catalogs#30
suhdonghwi merged 4 commits intomainfrom
feat/accurate-validation-2

Conversation

@suhdonghwi
Copy link
Collaborator

This PR changes validation behavior to show "unused catalog protocols" warnings/errors only if the unused catalog track is one of the workspace's default catalog tracks.

If a workspace does not have default catalog track, it considers every catalog track is a default catalog track.

@suhdonghwi suhdonghwi requested a review from parksb November 9, 2025 10:46
@suhdonghwi suhdonghwi marked this pull request as draft November 9, 2025 10:47
@suhdonghwi suhdonghwi marked this pull request as ready for review November 9, 2025 10:49
@parksb
Copy link
Member

parksb commented Nov 9, 2025

Would you write a case for default: max in warnings.test.ts file? Previously, testing in the default-groups.test.ts file was sufficient, but now it would be better to test warning messages separately.

@suhdonghwi
Copy link
Collaborator Author

I have added a test case!

Copy link
Member

@parksb parksb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suhdonghwi suhdonghwi merged commit 93acf52 into main Nov 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants